check_makefile_targets¶

def check_makefile(filepath: Path, recommended: set[str] = RECOMMENDED_TARGETS) -> list[str]:
    """Check a Makefile for recommended targets.

    Args:
        filepath: Path to the Makefile
        recommended: Target names that must be present (defaults to RECOMMENDED_TARGETS)

    Returns:
        List of warning messages (empty if all recommended targets exist)
    """
    warnings: list[str] = []

    try:
        content = filepath.read_text(encoding="utf-8")
    except FileNotFoundError:
        return [f"File not found: {filepath}"]

    targets = extract_targets(content)

    # Only check the main Makefile for recommended targets
    if filepath.name == "Makefile":
        missing = recommended - targets
        if missing:
            warnings.append(f"Missing recommended targets: {', '.join(sorted(missing))}")

    return warnings

def main(argv: list[str] | None = None) -> int:
    """Main entry point for the hook."""
    parser = argparse.ArgumentParser(description="Check Makefile for recommended targets")
    parser.add_argument(
        "filenames",
        nargs="*",
        help="Filenames to check",
    )
    parser.add_argument(
        "--strict",
        action="store_true",
        help="Exit with error if recommended targets are missing",
    )
    parser.add_argument(
        "--target",
        action="append",
        metavar="NAME",
        help="Required target name; repeatable. When given, replaces the default set.",
    )
    parser.add_argument(
        "--extend-target",
        action="append",
        metavar="NAME",
        help="Extra required target name; repeatable. Added on top of the active set.",
    )
    args = parser.parse_args(argv)

    recommended = resolve_recommended_targets(args.target, args.extend_target)

    retval = 0
    for filename in args.filenames:
        filepath = Path(filename)
        warnings = check_makefile(filepath, recommended)
        if warnings:
            print(f"{filename}:")
            for warning in warnings:
                print(f"  - {warning}")
            if args.strict:
                retval = 1

    return retval

def resolve_recommended_targets(targets: list[str] | None, extra_targets: list[str] | None) -> set[str]:
    """Build the effective set of required targets from the CLI options.

    Args:
        targets: Values of ``--target``. When non-empty they *replace* the defaults.
        extra_targets: Values of ``--extend-target``, always *added* to the active set.

    Returns:
        The set of target names a Makefile is expected to define.
    """
    base = set(targets) if targets else set(RECOMMENDED_TARGETS)
    return base | set(extra_targets or [])